Skip to content

fix: 'asc' will not exit with exit code 1 after compile failing(#2311) #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix: 'asc' will not exit with exit code 1 after compile failing(#2311) #2312

merged 1 commit into from
Jun 20, 2022

Conversation

HerrCai0907
Copy link
Member

@HerrCai0907 HerrCai0907 commented Jun 8, 2022 •
edited
Loading

Fix #2311
⯈receive error correctly from main
⯈pass the exit code from spawnSync

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@HerrCai0907
Copy link
Member Author

HerrCai0907 commented Jun 14, 2022 •
edited
Loading

@dcodeIO could this PR be merged?

@dcodeIO dcodeIO merged commit 9987e63 into AssemblyScript:main Jun 20, 2022
@dcodeIO
Copy link
Member

dcodeIO commented Jun 20, 2022

Thanks! :)

@HerrCai0907 HerrCai0907 deleted the fix-exitCode branch June 20, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'asc' will not exit with exit code 1 after compile failing
2 participants
@HerrCai0907 @dcodeIO