fix: the function signatures of two interfaces are the same #1855 #2272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technohippy
changed the title
dcodeIO
reviewed
Apr 23, 2022
Comment on lines
+840
to
+848
| if (!isInterface) { | ||
| // check `this` type | ||
| var thisThisType = this.thisType; | ||
| var targetThisType = target.thisType; | ||
| if (thisThisType) { | ||
| if (!targetThisType || !thisThisType.isAssignableTo(targetThisType)) return false; | ||
| } else if (targetThisType) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
One case I could imagine where skipping the check entirely leads to issues is an override of (this: i32, ...): ..., where then there would be two classes extending the same interface with an incompatible this type. Perhaps keep a check for managed-ness / strict assignability of the types?
|
Has been tackled alongside #2548 iirc. The test used in this PR passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⯈fix #1855