Skip to content

fix: compileSwitchStatement will hide inner conditional flags #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2021
Merged

fix: compileSwitchStatement will hide inner conditional flags #2102

merged 3 commits into from
Nov 11, 2021

Conversation

HerrCai0907
Copy link
Member

@HerrCai0907 HerrCai0907 commented Oct 22, 2021 •
edited
Loading

⯈fix issue: do-while + switch + continue cause compiler crash #2101
⯈when compileSwitchStatement, commonConditional don't consider the situations that CONTINUES should change to CONDITIONALLY_CONTINUES in FlowFlags.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey
Copy link
Member

MaxGraey commented Oct 22, 2021 •
edited
Loading

Regarding webpack error in CI. You could fix it by adding different hashFunction in webpack.config. See this fixes in another PR: https://github.com/AssemblyScript/assemblyscript/pull/2057/files#diff-1fb26bc12ac780c7ad7325730ed09fc4c2c3d757c276c3dacc44bfe20faf166f

@MaxGraey
Copy link
Member

MaxGraey commented Oct 22, 2021 •
edited
Loading

Or just better to wait for this fix: #2103

@MaxGraey
Copy link
Member

sync with main branch please

dcodeIO
dcodeIO approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there'll be more work necessary to get this perfect, but since this fixes the reported problem I think it's fine to merge for now :)

Just a nit with the naming, which I can apply myself.

@dcodeIO dcodeIO merged commit 70013e9 into AssemblyScript:main Nov 11, 2021
@dcodeIO
Copy link
Member

dcodeIO commented Nov 11, 2021

Thanks! :)

@HerrCai0907 HerrCai0907 deleted the issue-2101 branch December 6, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HerrCai0907 @MaxGraey @dcodeIO