Skip to content

Internal field names should use instance notation #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/program.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3284,7 +3284,7 @@ export abstract class VariableLikeElement extends TypedElement {
super(
kind,
name,
mangleInternalName(name, parent, false),
mangleInternalName(name, parent, declaration.is(CommonFlags.INSTANCE)),
parent.program,
parent,
declaration
Expand Down
24 changes: 12 additions & 12 deletions tests/compiler/field-initialization-errors.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,18 @@
"asc_flags": [
],
"stderr": [
"TS2564: Property 'field-initialization-errors/Ref.a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor.a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_InlineCtor.a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Branch.a' has no initializer",
"TS2565: Property 'field-initialization-errors/Ref_Ctor_Use_Init.a' is used before being assigned.",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Call_Init.a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Prop_Init.a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Callwith_Init.a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Alias_Init.a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Assign_Init.a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Icallwith_Init.a' has no initializer",
"TS2564: Property 'field-initialization-errors/Inherit_Base.a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref#a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor#a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_InlineCtor#a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Branch#a' has no initializer",
"TS2565: Property 'field-initialization-errors/Ref_Ctor_Use_Init#a' is used before being assigned.",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Call_Init#a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Prop_Init#a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Callwith_Init#a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Alias_Init#a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Assign_Init#a' has no initializer",
"TS2564: Property 'field-initialization-errors/Ref_Ctor_Icallwith_Init#a' has no initializer",
"TS2564: Property 'field-initialization-errors/Inherit_Base#a' has no initializer",
"EOF"
]
}
2 changes: 1 addition & 1 deletion tests/compiler/field-initialization-warnings.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
],
"stderr": [
"AS906: Unnecessary definite assignment.",
"AS233: Property 'field-initialization-warnings/Ref_Ctor_Init.a' is always assigned",
"AS233: Property 'field-initialization-warnings/Ref_Ctor_Init#a' is always assigned",
"EOF"
]
}
5 changes: 5 additions & 0 deletions tests/compiler/field.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"asc_flags": [
],
"asc_rtrace": true
}
Loading