Skip to content

Renumber now-pedantic diagnostic from 232 to 907 #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Renumber now-pedantic diagnostic from 232 to 907 #2001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/diagnosticMessages.generated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export enum DiagnosticCode {
Property_0_only_has_a_setter_and_is_missing_a_getter = 229,
_0_keyword_cannot_be_used_here = 230,
A_class_with_a_constructor_explicitly_returning_something_else_than_this_must_be_final = 231,
Exported_generic_function_or_class_has_no_concrete_instances = 232,
Property_0_is_always_assigned_before_being_used = 233,
Expression_refers_to_a_static_element_that_does_not_compile_to_a_value_at_runtime = 234,
Importing_the_table_disables_some_indirect_call_optimizations = 901,
Expand All @@ -55,6 +54,7 @@ export enum DiagnosticCode {
Indexed_access_may_involve_bounds_checking = 904,
Explicitly_returning_constructor_drops_this_allocation = 905,
Unnecessary_definite_assignment = 906,
Exported_generic_function_or_class_has_no_concrete_instances = 907,
Unterminated_string_literal = 1002,
Identifier_expected = 1003,
_0_expected = 1005,
Expand Down Expand Up @@ -228,7 +228,6 @@ export function diagnosticCodeToString(code: DiagnosticCode): string {
case 229: return "Property '{0}' only has a setter and is missing a getter.";
case 230: return "'{0}' keyword cannot be used here.";
case 231: return "A class with a constructor explicitly returning something else than 'this' must be '@final'.";
case 232: return "Exported generic function or class has no concrete instances.";
case 233: return "Property '{0}' is always assigned before being used.";
case 234: return "Expression refers to a static element that does not compile to a value at runtime.";
case 901: return "Importing the table disables some indirect call optimizations.";
Expand All @@ -237,6 +236,7 @@ export function diagnosticCodeToString(code: DiagnosticCode): string {
case 904: return "Indexed access may involve bounds checking.";
case 905: return "Explicitly returning constructor drops 'this' allocation.";
case 906: return "Unnecessary definite assignment.";
case 907: return "Exported generic function or class has no concrete instances.";
case 1002: return "Unterminated string literal.";
case 1003: return "Identifier expected.";
case 1005: return "'{0}' expected.";
Expand Down
2 changes: 1 addition & 1 deletion src/diagnosticMessages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
"Property '{0}' only has a setter and is missing a getter.": 229,
"'{0}' keyword cannot be used here.": 230,
"A class with a constructor explicitly returning something else than 'this' must be '@final'.": 231,
"Exported generic function or class has no concrete instances.": 232,
"Property '{0}' is always assigned before being used.": 233,
"Expression refers to a static element that does not compile to a value at runtime.": 234,

Expand All @@ -51,6 +50,7 @@
"Indexed access may involve bounds checking.": 904,
"Explicitly returning constructor drops 'this' allocation.": 905,
"Unnecessary definite assignment.": 906,
"Exported generic function or class has no concrete instances.": 907,

"Unterminated string literal.": 1002,
"Identifier expected.": 1003,
Expand Down
10 changes: 5 additions & 5 deletions tests/compiler/export-generic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
"--pedantic"
],
"stderr": [
"AS232: Exported generic function or class has no concrete instances.",
"AS907: Exported generic function or class has no concrete instances.",
"export function testFunction<T>",
"AS232: Exported generic function or class has no concrete instances.",
"AS907: Exported generic function or class has no concrete instances.",
"export class TestClass<T>",
"AS232: Exported generic function or class has no concrete instances.",
"AS907: Exported generic function or class has no concrete instances.",
"public testMethod<T>()",
"AS232: Exported generic function or class has no concrete instances.",
"AS907: Exported generic function or class has no concrete instances.",
"export function testNamespacedFunction<T>",
"AS232: Exported generic function or class has no concrete instances.",
"AS907: Exported generic function or class has no concrete instances.",
"export class TestNamespacedClass<T>"
]
}