Skip to content

Fixed stdlib builtins not working with typedoc #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Fixed stdlib builtins not working with typedoc #1894

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a71387b
Fixed stdlib builtins not working with typedoc
torch2424 Jun 9, 2021
c3ad406
Added the changetype instead of zero
torch2424 Jun 9, 2021
3eacd5d
Made suggested changes
torch2424 Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions std/assembly/builtins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2302,11 +2302,17 @@ export abstract class i31 { // FIXME: usage of 'new' requires a class :(

// @ts-ignore: decorator
@builtin
static new(value: i32): i31ref { return unreachable(); }
static new(value: i32): i31ref {
unreachable();
return changetype<i31ref>(0);
}

// @ts-ignore: decorator
@builtin
static get(i31expr: i31ref): i32 { return unreachable(); }
static get(i31expr: i31ref): i32 {
unreachable();
return 0;
}
}

/* eslint-disable @typescript-eslint/no-unused-vars */
Expand Down