Skip to content

fix: internalPath in parseFile is not same with Source #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Apr 29, 2021

in Souce:

var internalPath = mangleInternalPath(normalizedPath);

in parseFile:

var normalizedPath = normalizePath(path);
 var internalPath = mangleInternalPath(path);

I got two path string:

  • ./examples/foo
  • examples/foo

@MaxGraey
Copy link
Member

@willemneal could you check this as well?

@willemneal
Copy link
Contributor

Yeah looks good to me! Good catch!

@MaxGraey MaxGraey merged commit 802a233 into AssemblyScript:master Apr 29, 2021
@MaxGraey
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants