Skip to content

fix: Fix usage of namespaced classes #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix: Fix usage of namespaced classes #1791

merged 1 commit into from
Apr 7, 2021

Conversation

saulecabrera
Copy link
Contributor

@saulecabrera saulecabrera commented Apr 7, 2021

This patch reports a diagnostic when using a namespaced class (or any other construct)
that lacks a runtime representation as an expression.

Fixes #1790

  • I've read the contributing guidelines

This patch reports a diagnostic when using a class (or any other construct)
that lacks a runtime representation as an expression
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@dcodeIO dcodeIO merged commit a073e1c into AssemblyScript:master Apr 7, 2021
@saulecabrera saulecabrera deleted the fix-usage-of-namespaced-classes branch April 8, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning namespaced classes to a variable results in an assertion error
2 participants