Backport fixes from musl's libc#1749
Merged
dcodeIO merged 5 commits intoAssemblyScript:masterfrom Mar 27, 2021
MaxGraey:backport-musl-math-fixes
Merged
Backport fixes from musl's libc#1749dcodeIO merged 5 commits intoAssemblyScript:masterfrom MaxGraey:backport-musl-math-fixes
dcodeIO merged 5 commits intoAssemblyScript:masterfrom
MaxGraey:backport-musl-math-fixes
Conversation
Member
|
I am not a fan of the formatting changes, as it makes PRs a little hard to grasp. I am OK with leaving it this way, though, but can you perhaps at a line comment (here on GH in the PR) with a bit of background where the code changes are and what they do? |
MaxGraey
commented
Mar 22, 2021
MaxGraey
commented
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch references 1 and 2