-
-
Notifications
You must be signed in to change notification settings - Fork 670
Uri encode / decode #1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uri encode / decode #1733
Conversation
I find it hard to verify by hand that there isn't an OOB load or store somewhere. The test is using Rtrace, though, which indicates that there isn't, but I'm still a bit hesitant to blindly approve. I think we need a lot more comments here, for example
|
Because that’s what ECMA‑262 specifies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on what we just talked about offline, I'd like to retract my objections and leave it up to you, @MaxGraey :)
Sure. I'll add more comments before merging |
Implement following global functions:
decodeURI
encodeURI
decodeURIComponent
encodeURIComponent
I've read the contributing guidelines