Update Binaryen #1700
Merged
Update Binaryen #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some notes I made so I don't forget // Features (WebAssembly/binaryen#3603)
SIMD constants// Unary
// Binary
// SIMDTernary
// SIMDLoad
// SIMDLoadStoreLane
// SIMDWiden
// Prefetch (obsolete)
// RefAs (WebAssembly/binaryen#3628)
// BrOn
// RefIs (WebAssembly/binaryen#3605)
// I31New
// I31Get
// Table (WebAssembly/binaryen#3604)
Turns out that most of the Unary/Binary/SIMD constants fall under SIMD, and have TODO comments in Binaryen. While I found the implementation status document meanwhile, I'll wait a bit on these so I don't accidentally get into the way. |
|
Seems it still slower on 1.7 times for binaryen's optimization compared with v98. Could we create issue about this in Binaryen repo? |
|
I haven't investigated the slowdown myself, so I guess you have more information on it than I have. Could you make one? :) |
|
Impressive work. How to do implement such migration? Updating the lib version and seeing what fails? |
|
My process there is typically:
|
|
Interesting, thank you, that's really a nice update process. |
|
I'm wondering may be this WebAssembly/binaryen#3609 fix issue with not always de-dupllicate functions? |
|
Going to check once we have a build :) |
MaxGraey
reviewed
Feb 25, 2021
|
@MaxGraey it would be great if you could file a Binaryen issue for the slowdown. |
Seems the fixtures didn't change |
|
Making myself a handy list of SIMD instructions so I don't forget to check one // Memory
// Basic
// Splat
// Lane
// Cmp
// v128
// Load lane
// Float conversion
// iAxB
// fAxB
// Conversion
TODO
|
MaxGraey
reviewed
Feb 28, 2021
|
I guess this one is fine to go now, given that the remaining constants and bindings are missing, we don't have a cast story for GC types yet, so I'll have to look into this again anyhow. The lists above should be useful then. |
|
@dcodeIO Thanks for this excellent job! I'll check little bit later. But I'm would like report about slowdown issue of binaryen. Try to bisect version when this happened |
MaxGraey
approved these changes
Mar 5, 2021
|
Right, we cannot yet make proper use of these without an initial implementation of Wasm GC, but it's good to keep the bindings up to date already so everything's there once we can :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, this gets us up to date with the latest changes in Binaryen. Quite a bit of chaos here with missing C-APIs that may be good to tackle.