Skip to content

Bundle loader and rtrace with asc #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Bundle loader and rtrace with asc #1641

merged 1 commit into from
Jan 29, 2021

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jan 29, 2021

Should fix editor breakage on the website. The issue was introduced by asc now needing the loader and rtrace for Wasm builds of the compiler, with the configuration to make these externals causing the issue apparently.

  • I've read the contributing guidelines

@dcodeIO dcodeIO merged commit f38c838 into master Jan 29, 2021
@MaxGraey
Copy link
Member

it didn't seem to help 😞

@dcodeIO
Copy link
Member Author

dcodeIO commented Jan 30, 2021

It seems to be working for me now. Note that the website CI job runs half an hour later than the compiler :)

@MaxGraey
Copy link
Member

MaxGraey commented Jan 30, 2021

Yes! Now can confirm this as well

@dcodeIO dcodeIO deleted the fix-browser-asc branch June 1, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants