Skip to content

Update binaryen. Slightly improve pass pipeline #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2020
Merged

Update binaryen. Slightly improve pass pipeline #1526

merged 4 commits into from
Oct 30, 2020

Conversation

MaxGraey
Copy link
Member

After WebAssembly/binaryen#3274 we need slightly refactor our pass pipeline

  • I've read the contributing guidelines

@MaxGraey MaxGraey added dependencies Pull requests that update a dependency file enhancement labels Oct 28, 2020
@MaxGraey MaxGraey requested a review from dcodeIO October 28, 2020 01:08
@MaxGraey
Copy link
Member Author

MaxGraey commented Oct 28, 2020 •
edited
Loading

I guess better wait next binaryen's version which fix ZeroRemover issue before merge

@MaxGraey
Copy link
Member Author

MaxGraey commented Oct 29, 2020 •
edited
Loading

Now it ready for merging)

@dcodeIO dcodeIO merged commit 353807e into AssemblyScript:master Oct 30, 2020
@MaxGraey MaxGraey deleted the update-binaryen branch October 30, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO