Skip to content

fix(compiler): Implement proper left / right cyclic builtin rotation for small integers #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2020

Conversation

MaxGraey
Copy link
Member

Fix #1492

  • I've read the contributing guidelines

@MaxGraey MaxGraey requested a review from dcodeIO October 10, 2020 18:22
@MaxGraey MaxGraey changed the title Implement proper left / right cyclic builtin rotation for small integers fix(compiler): Implement proper left / right cyclic builtin rotation for small integers Oct 10, 2020
@MaxGraey MaxGraey requested a review from dcodeIO October 12, 2020 10:39
@dcodeIO dcodeIO merged commit 041d35b into AssemblyScript:master Oct 12, 2020
@dcodeIO
Copy link
Member

dcodeIO commented Oct 12, 2020

Nice find, and thanks for fixing! :)

@MaxGraey MaxGraey deleted the fix-1492 branch October 12, 2020 15:48
@github-actions
Copy link

🎉 This PR is included in version 0.15.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotation shift builtins for small typed integers incorrectly implemented
2 participants