Merge oldest parent first

[willemneal]

This adds more tests and changes the order of merges so that cli > target > options > parent.target ...

Now adding expected.json, which will be checked if --showConfig is passed to the test runner.

Changed addDefaults to return a new options object instead of editing the passed one.

[jtenner]

This is the wrong order. The asconfig options need to be overridden by cli args.

The options.merge function puts the parent as the third parameter, preferring the second argument.

Did I miss something or mis-implement this algorithm?

[willemneal]

You're right. Just added more tests and sure enough it ignores the CLI args. The issue was that the defaults for the args was being set before the config properties were being added. So if you treat args as the current config it will prioritize the defaults. I just changed it to not add the defaults right away so we can get just the args passed and things seem to work.

[dcodeIO]

The fixes to util/options look fine, but I'm wondering if most of the state keeping in cli/asc can be avoided. For instance, the intended order for the merge algorithm (preferring current over parent) was to start with parsed CLI args, and then subsequently merge the next set of options taking precedence over what's still to merge, i.e.

current = parse(..., false)
while (asConfig = getNextAsconfig()) {
  if (asConfig.target) {
    current = merge(current, asConfig.target)
  }
  current = merge(current, asConfig.options)
}
current = addDefaults(current)
// use current

Can you elaborate why this isn't working, i.e. needs temporary cliArgs, an array of configs etc.?

[willemneal]

We need to split up the CLI args because the defaults in args are needed, e.g. args.target, args.config. I took your advice and removed the configs array and returned to @jtenner's original design.

[dcodeIO]

This is happening too early, and is instead intended to be performed as the last step once CLI args and asconfigs have been fully processed. For that, we just need to apply the defaults for target and config early, independently of populating their values. Can either hardcode these or pull them from the config.

[willemneal]

I changed addDefaults so that it returns a new object. This way opts.options is untouched. Then at the end of the config it is merged back into args. It was the only way I found that fixed the issues your having in #1406.

[dcodeIO]

Hmm, I suspect that the underlying issue is that the relative path transform is applied to imported file names, in turn stripping the . from ./a, resulting in the packages test trying to find a, which resolves differently. While the changes in ordering here apparently prevent this, somehow, that doesn't look like a proper fix.