Skip to content

Implement different bases (radix) for int#toString #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
May 25, 2020
Merged

Implement different bases (radix) for int#toString #1284

merged 28 commits into from
May 25, 2020

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented May 19, 2020 •
edited
Loading

this PR introduce:

  1. Special fast path for itoa funcs with radix = 16;
  2. General path for radix differ than 10 or 16 with fast paths if radix is pow of two.
  3. remove generic itoa<T>
  4. tests

MaxGraey
MaxGraey commented May 19, 2020
View reviewed changes
@MaxGraey MaxGraey changed the title Implement different bases (redix) for toString Implement different bases (radix) for toString May 19, 2020
@MaxGraey MaxGraey changed the title Implement different bases (radix) for toString Implement different bases (radix) for int#toString May 19, 2020
@MaxGraey MaxGraey marked this pull request as ready for review May 20, 2020 06:05
@MaxGraey MaxGraey requested a review from dcodeIO May 20, 2020 06:06
dcodeIO
dcodeIO reviewed May 21, 2020
View reviewed changes
dcodeIO
dcodeIO reviewed May 21, 2020
View reviewed changes
dcodeIO
dcodeIO reviewed May 21, 2020
View reviewed changes
@dcodeIO
Copy link
Member

dcodeIO commented May 25, 2020

Didn't check every single detail, but code looks good and tests including the new ones are passing, hence merging :)

@dcodeIO dcodeIO merged commit 0457b11 into AssemblyScript:master May 25, 2020
@MaxGraey MaxGraey deleted the to-string-radix branch May 25, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO