Skip to content

tsconfig can use node resolution instead of relative #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

willemneal
Copy link
Contributor

This way when asinit is used globally it won't point to the global definition and is less fragile.

@dcodeIO
Copy link
Member

dcodeIO commented Mar 13, 2020

Cool, didn't know this is possible. Does this work if the compiler has been installed globally exclusively?

@willemneal
Copy link
Contributor Author

Just tried it and it doesn't; personally I've found it useful to have the assemblyscript local for the version and CI, etc

@dcodeIO
Copy link
Member

dcodeIO commented Mar 14, 2020

Perhaps the TS guys are interested in a PR to make this possible. Would be nice to make it just work in all circumstances :)

@dcodeIO
Copy link
Member

dcodeIO commented Mar 14, 2020

In the meantime, would it be possible to make this conditional? Let's say asinit finds that assemblyscript is local, it would use node resolution, and otherwise use the exact path as before?

@dcodeIO
Copy link
Member

dcodeIO commented Apr 26, 2020

Any thoughts on this? :)

@dcodeIO
Copy link
Member

dcodeIO commented Jun 10, 2020

Closing this PR in favor of #1322.

@dcodeIO dcodeIO closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants