The type is misordered when use `abstract` generic class

[yjhmelody]

See https://github.com/jtenner/as-pect/issues/349

ERROR TS2322: Type '(this: assembly/UInt/UInt32/UInt32) => i32' is not assignable to type '(this: assembly/AbstractInt/AbstractInt<u64>) => i32'.

     _byteLength(): i32 {
     ~~~~~~~~~~~
 in assembly/UInt/UInt32.ts(21,5)

ERROR TS2322: Type '(this: assembly/UInt/UInt64/UInt64) => i32' is not assignable to type '(this: assembly/AbstractInt/AbstractInt<u32>) => i32'.

     _byteLength(): i32 {
     ~~~~~~~~~~~
 in assembly/UInt/UInt64.ts(21,5)

The above types are swapped.

The quantities of the various types below are correct, but they do not match the types.

ERROR TS2322: Type '(this: assembly/UInt/UInt16/UInt16) => i32' is not assignable to type '(this: assembly/AbstractInt/AbstractInt<u64>) => i32'.

     _byteLength(): i32 {
     ~~~~~~~~~~~
 in assembly/UInt/UInt16.ts(21,5)

ERROR TS2322: Type '(this: assembly/UInt/UInt32/UInt32) => i32' is not assignable to type '(this: assembly/AbstractInt/AbstractInt<u64>) => i32'.

     _byteLength(): i32 {
     ~~~~~~~~~~~
 in assembly/UInt/UInt32.ts(21,5)

ERROR TS2322: Type '(this: assembly/UInt/UInt16/UInt16) => i32' is not assignable to type '(this: assembly/AbstractInt/AbstractInt<u32>) => i32'.

     _byteLength(): i32 {
     ~~~~~~~~~~~
 in assembly/UInt/UInt16.ts(21,5)

ERROR TS2322: Type '(this: assembly/UInt/UInt64/UInt64) => i32' is not assignable to type '(this: assembly/AbstractInt/AbstractInt<u32>) => i32'.

     _byteLength(): i32 {
     ~~~~~~~~~~~
 in assembly/UInt/UInt64.ts(21,5)

ERROR TS2322: Type '(this: assembly/UInt/UInt32/UInt32) => i32' is not assignable to type '(this: assembly/AbstractInt/AbstractInt<u16>) => i32'.

     _byteLength(): i32 {
     ~~~~~~~~~~~
 in assembly/UInt/UInt32.ts(21,5)

ERROR TS2322: Type '(this: assembly/UInt/UInt64/UInt64) => i32' is not assignable to type '(this: assembly/AbstractInt/AbstractInt<u16>) => i32'.

     _byteLength(): i32 {
     ~~~~~~~~~~~
 in assembly/UInt/UInt64.ts(21,5)

I reproduce it using asc, so it's as bug.

This is a minimal example:

export abstract class AbstractInt<T> {
    protected _value: T;

    constructor(value: T) {
        this._value = value;
    }

    get _byteLength(): i32 {
        return 0;
    }

    @inline
    encodedLength(): i32 {
        return this._byteLength;
    }
}

export class UInt8 extends AbstractInt<u8> {
    @inline
    get _byteLength(): i32 {
        return 1;
    }

    constructor(value: u8 = 0) {
        super(value);
    }
}

export class Int8 extends AbstractInt<i8> {
    @inline
    get _byteLength(): i32 {
        return 1;
    }

    constructor(value: u8 = 0) {
        super(value);
    }
}

• Still the same phenomenon, if these types appear in one file, an error will occur.
• If sub class overload encodedLength, the error don't happen.

[dcodeIO]

Attempted to reproduce the issue given the example. Not seeing the respective errors, and the exports seem OK:

 (export "UInt8" (global $empty/UInt8))
 (export "UInt8#get:_value" (func $empty/AbstractInt<u8>#get:_value))
 (export "UInt8#set:_value" (func $empty/AbstractInt<u8>#set:_value))
 (export "UInt8#constructor" (func $empty/UInt8#constructor@varargs))
 (export "UInt8#get:_byteLength" (func $empty/UInt8#get:_byteLength))
 (export "UInt8#encodedLength" (func $empty/AbstractInt<u8>#encodedLength))
 (export "Int8" (global $empty/Int8))
 (export "Int8#get:_value" (func $empty/AbstractInt<i8>#get:_value))
 (export "Int8#set:_value" (func $empty/AbstractInt<i8>#set:_value))
 (export "Int8#constructor" (func $empty/Int8#constructor@varargs))
 (export "Int8#get:_byteLength" (func $empty/Int8#get:_byteLength))
 (export "Int8#encodedLength" (func $empty/AbstractInt<i8>#encodedLength))

I remember however that I looked at this before and saw that something was off. Hence wondering, has this perhaps been fixed meanwhile (#2056?), or am I missing something?

[yjhmelody]

Ok, I will to try the new version. Thanks!
I think it is better to keep the bug label, I can reproduce it in version 0.18 but it works fine in 0.19.11.

It is not clear in which version it was fixed.

$ npx asc --version
Version 0.19.11
$ npx asc ./foo.ts --noEmit

$ asc --version
Version 0.18.28

$ asc ./foo.ts
ERROR TS2322: Type '(this: a/Int8) => i32' is not assignable to type '(this: a/AbstractInt<u8>) => i32'.

     get _byteLength(): i32 {
         ~~~~~~~~~~~
 in a.ts(31,9)

ERROR TS2322: Type '(this: a/UInt8) => i32' is not assignable to type '(this: a/AbstractInt<i8>) => i32'.

     get _byteLength(): i32 {
         ~~~~~~~~~~~
 in a.ts(20,9)

FAILURE 2 compile error(s)