[Hub Generated] Review request for Microsoft.Cache to add version sta…

…ble/2020-12-01 (Azure#15674) * Fixing swagger correctness issues * reverting the newly added status code * prettier formatting * adding custom words * s360 issue fix * Fixing model validation error Co-authored-by: Praveenkumar Ravikumar <prravikumar@microsoft.com>
AsrOneSdk · Sep 15, 2021 · 921c854 · 921c854
1 parent 767f6ae
commit 921c854
Show file tree

Hide file tree

Showing 5 changed files with 172 additions and 64 deletions.
diff --git a/custom-words.txt b/custom-words.txt
@@ -1141,8 +1141,10 @@ mariadb
 Marketo
 marketplaceagreementsapi
 marketplaceordering
+maxclients
 maxcoordinates
 MAXERRORS
+maxfragmentationmemory
 maximumblobsize
 maxmemory
 maxpagesize

diff --git a/.../Microsoft.Cache/stable/2020-06-01/examples/RedisCacheListPrivateEndpointConnections.json b/.../Microsoft.Cache/stable/2020-06-01/examples/RedisCacheListPrivateEndpointConnections.json
@@ -8,40 +8,42 @@
   },
   "responses": {
     "200": {
-      "body": [
-        {
-          "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
-          "name": "pectest01",
-          "type": "Microsoft.Cache/Redis/privateEndpointConnections",
-          "properties": {
-            "provisioningState": "Succeeded",
-            "privateEndpoint": {
-              "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
-            },
-            "privateLinkServiceConnectionState": {
-              "status": "Approved",
-              "description": "Auto-Approved",
-              "actionsRequired": "None"
+      "body": {
+        "value": [
+          {
+            "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
+            "name": "pectest01",
+            "type": "Microsoft.Cache/Redis/privateEndpointConnections",
+            "properties": {
+              "provisioningState": "Succeeded",
+              "privateEndpoint": {
+                "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
+              },
+              "privateLinkServiceConnectionState": {
+                "status": "Approved",
+                "description": "Auto-Approved",
+                "actionsRequired": "None"
+              }
             }
-          }
-        },
-        {
-          "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
-          "name": "pectest01",
-          "type": "Microsoft.Cache/Redis/privateEndpointConnections",
-          "properties": {
-            "provisioningState": "Succeeded",
-            "privateEndpoint": {
-              "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
-            },
-            "privateLinkServiceConnectionState": {
-              "status": "Approved",
-              "description": "Auto-Approved",
-              "actionsRequired": "None"
+          },
+          {
+            "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
+            "name": "pectest01",
+            "type": "Microsoft.Cache/Redis/privateEndpointConnections",
+            "properties": {
+              "provisioningState": "Succeeded",
+              "privateEndpoint": {
+                "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
+              },
+              "privateLinkServiceConnectionState": {
+                "status": "Approved",
+                "description": "Auto-Approved",
+                "actionsRequired": "None"
+              }
             }
           }
-        }
-      ]
+        ]
+      }
     }
   }
 }
diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2020-06-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2020-06-01/redis.json
@@ -1819,6 +1819,53 @@
       "properties": {
         "redisConfiguration": {
           "type": "object",
+          "properties": {
+            "rdb-backup-enabled": {
+              "type": "string",
+              "description": "Specifies whether the rdb backup is enabled"
+            },
+            "rdb-backup-frequency": {
+              "type": "string",
+              "description": "Specifies the frequency for creating rdb backup"
+            },
+            "rdb-backup-max-snapshot-count": {
+              "type": "string",
+              "description": "Specifies the maximum number of snapshots for rdb backup"
+            },
+            "rdb-storage-connection-string": {
+              "type": "string",
+              "description": "The storage account connection string for storing rdb file"
+            },
+            "aof-storage-connection-string-0": {
+              "type": "string",
+              "description": "First storage account connection string"
+            },
+            "aof-storage-connection-string-1": {
+              "type": "string",
+              "description": "Second storage account connection string"
+            },
+            "maxfragmentationmemory-reserved": {
+              "type": "string",
+              "description": "Value in megabytes reserved for fragmentation per shard"
+            },
+            "maxmemory-policy": {
+              "type": "string",
+              "description": "The eviction strategy used when your data won't fit within its memory limit."
+            },
+            "maxmemory-reserved": {
+              "type": "string",
+              "description": "Value in megabytes reserved for non-cache usage per shard e.g. failover."
+            },
+            "maxmemory-delta": {
+              "type": "string",
+              "description": "Value in megabytes reserved for non-cache usage per shard e.g. failover."
+            },
+            "maxclients": {
+              "type": "string",
+              "description": "The max clients config",
+              "readOnly": true
+            }
+          },
           "additionalProperties": {
             "type": "string"
           },
@@ -2527,7 +2574,11 @@
         },
         "linkedRedisCacheLocation": {
           "type": "string",
-          "description": "Location of the linked redis cache."
+          "description": "Location of the linked redis cache.",
+          "x-ms-mutability": [
+            "create",
+            "read"
+          ]
         },
         "serverRole": {
           "type": "string",

diff --git a/.../Microsoft.Cache/stable/2020-12-01/examples/RedisCacheListPrivateEndpointConnections.json b/.../Microsoft.Cache/stable/2020-12-01/examples/RedisCacheListPrivateEndpointConnections.json
@@ -8,40 +8,42 @@
   },
   "responses": {
     "200": {
-      "body": [
-        {
-          "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
-          "name": "pectest01",
-          "type": "Microsoft.Cache/Redis/privateEndpointConnections",
-          "properties": {
-            "provisioningState": "Succeeded",
-            "privateEndpoint": {
-              "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
-            },
-            "privateLinkServiceConnectionState": {
-              "status": "Approved",
-              "description": "Auto-Approved",
-              "actionsRequired": "None"
+      "body": {
+        "value": [
+          {
+            "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
+            "name": "pectest01",
+            "type": "Microsoft.Cache/Redis/privateEndpointConnections",
+            "properties": {
+              "provisioningState": "Succeeded",
+              "privateEndpoint": {
+                "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
+              },
+              "privateLinkServiceConnectionState": {
+                "status": "Approved",
+                "description": "Auto-Approved",
+                "actionsRequired": "None"
+              }
             }
-          }
-        },
-        {
-          "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
-          "name": "pectest01",
-          "type": "Microsoft.Cache/Redis/privateEndpointConnections",
-          "properties": {
-            "provisioningState": "Succeeded",
-            "privateEndpoint": {
-              "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
-            },
-            "privateLinkServiceConnectionState": {
-              "status": "Approved",
-              "description": "Auto-Approved",
-              "actionsRequired": "None"
+          },
+          {
+            "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Cache/Redis/cachetest01/privateEndpointConnections/pectest01",
+            "name": "pectest01",
+            "type": "Microsoft.Cache/Redis/privateEndpointConnections",
+            "properties": {
+              "provisioningState": "Succeeded",
+              "privateEndpoint": {
+                "id": "/subscriptions/{subscriptionId}/resourceGroups/rgtest01/providers/Microsoft.Network/privateEndpoints/petest01"
+              },
+              "privateLinkServiceConnectionState": {
+                "status": "Approved",
+                "description": "Auto-Approved",
+                "actionsRequired": "None"
+              }
             }
           }
-        }
-      ]
+        ]
+      }
     }
   }
 }
diff --git a/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json b/specification/redis/resource-manager/Microsoft.Cache/stable/2020-12-01/redis.json
@@ -1822,6 +1822,53 @@
       "properties": {
         "redisConfiguration": {
           "type": "object",
+          "properties": {
+            "rdb-backup-enabled": {
+              "type": "string",
+              "description": "Specifies whether the rdb backup is enabled"
+            },
+            "rdb-backup-frequency": {
+              "type": "string",
+              "description": "Specifies the frequency for creating rdb backup"
+            },
+            "rdb-backup-max-snapshot-count": {
+              "type": "string",
+              "description": "Specifies the maximum number of snapshots for rdb backup"
+            },
+            "rdb-storage-connection-string": {
+              "type": "string",
+              "description": "The storage account connection string for storing rdb file"
+            },
+            "aof-storage-connection-string-0": {
+              "type": "string",
+              "description": "First storage account connection string"
+            },
+            "aof-storage-connection-string-1": {
+              "type": "string",
+              "description": "Second storage account connection string"
+            },
+            "maxfragmentationmemory-reserved": {
+              "type": "string",
+              "description": "Value in megabytes reserved for fragmentation per shard"
+            },
+            "maxmemory-policy": {
+              "type": "string",
+              "description": "The eviction strategy used when your data won't fit within its memory limit."
+            },
+            "maxmemory-reserved": {
+              "type": "string",
+              "description": "Value in megabytes reserved for non-cache usage per shard e.g. failover."
+            },
+            "maxmemory-delta": {
+              "type": "string",
+              "description": "Value in megabytes reserved for non-cache usage per shard e.g. failover."
+            },
+            "maxclients": {
+              "type": "string",
+              "description": "The max clients config",
+              "readOnly": true
+            }
+          },
           "additionalProperties": {
             "type": "string"
           },
@@ -2472,7 +2519,11 @@
         },
         "linkedRedisCacheLocation": {
           "type": "string",
-          "description": "Location of the linked redis cache."
+          "description": "Location of the linked redis cache.",
+          "x-ms-mutability": [
+            "create",
+            "read"
+          ]
         },
         "serverRole": {
           "type": "string",