Skip to content

Conversation

Changaco
Copy link
Member

This PR turns off Jinja's automatic reloading of templates when Aspen's automatic reloading of simplates is disabled.

From jinja's doc:

auto_reload
Some loaders load templates from locations where the template sources may change (ie: file system or database). If auto_reload is set to True (default) every time a template is requested the loader checks if the source changed and if yes, it will reload the template. For higher performance it’s possible to disable that.

@Changaco
Copy link
Member Author

CI is green, ready for review.

@chadwhitacre
Copy link
Contributor

Should there be a doc change along with this? Not sure how well-documented we have these plugins to begin with.

And do we want to add tests for this feature?

@chadwhitacre chadwhitacre merged commit bb147ed into master Feb 27, 2019
@Changaco Changaco deleted the jinja-auto-reload branch November 16, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants