Skip to content

Commit

Permalink
refactor(Angular.js): prevent Error variable name leak in tests
Browse files Browse the repository at this point in the history
Remove var Error = window.Error

window.Error is a read-only property in Apps Script.

Igor says, "we should just delete that line instead. I think it was
misko's attempt to get better closure minification, but it turns out
that it's actually hurting us after gzip (I verified it)."
  • Loading branch information
metaweta authored and IgorMinar committed Jan 29, 2013
1 parent 87ba822 commit e4cfb9d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/Angular.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ if ('i' !== 'I'.toLowerCase()) {
function fromCharCode(code) {return String.fromCharCode(code);}


var Error = window.Error,
/** holds major version number for IE or NaN for real browsers */
var /** holds major version number for IE or NaN for real browsers */
msie = int((/msie (\d+)/.exec(lowercase(navigator.userAgent)) || [])[1]),
jqLite, // delay binding since jQuery could be loaded after us.
jQuery, // delay binding
Expand Down

0 comments on commit e4cfb9d

Please sign in to comment.