Fix 5 UI/UX issues: keybinds, PTY resize, dead session crash#38
Merged
shranchi0 merged 1 commit intoAshirBorah:mainfrom Feb 18, 2026
Merged
Fix 5 UI/UX issues: keybinds, PTY resize, dead session crash#38shranchi0 merged 1 commit intoAshirBorah:mainfrom
shranchi0 merged 1 commit intoAshirBorah:mainfrom
Conversation
- Rename _on_viewer_resized → on_viewer_resized so Textual auto-dispatches the resize message (PTY resize was silently broken) - Add show_diff (F10) and set_group (F11) to DEFAULT_KEYBINDINGS so the keys actually fire - Add focus_search to _BINDING_META so Shift+Tab is registered with Textual - Catch OSError when sending input to a dead session instead of crashing - Remove redundant inline `import subprocess` (already imported at top)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_on_viewer_resized→on_viewer_resizedso Textual auto-dispatches the resize message (was silently broken — terminal content never resized with the window)show_diff(F10) andset_group(F11) toDEFAULT_KEYBINDINGS— these keys were registered in_BINDING_METAbut missing from the key manager, so pressing them did nothingfocus_searchto_BINDING_META— Shift+Tab was in the key manager but never registered with Textual's binding systemsend_input()in try/exceptOSErrorso typing into a dead session logs a debug message instead of crashingimport subprocess(already imported at module top)Test plan
ruff checkpassesruff format --checkpasses