-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): swipe up and down to switch between articles #589
Conversation
…shinch#502) * build(deps): bump up dependencies, compile sdk, and gradle version * build(deps): remove redundant safe-args plugin * build(deps): update Compose BOM to `2024.01.00` & compiler to `1.5.8`
* fix(i18n): configuration loss when switching locale * feat(locale): enable auto-localeconfig
* feat(i18n): add languages to in-app language picker * fix(i18n): locale system settings not working for Android 13 * feat(i18n): show selected language at settings page * fix(ci): ignore ExtraTranslation for linter * feat(i18n): add fallback in in-app language picker for A13+ * chore: clean up
This one is massive... man! e1864dab-8191-41c7-a889-3baed4069e07.mp4I hope it's some kind of hint. Cheers! |
@nvllz Thanks! This feature is not ready for use so far, as the one in the
The problem you encounter is actually because, when you open an article within the This PR was merged into main because we find it difficult to maintain two branches. I'll let you know if we have progress on this feature 🤞 |
This is a large PR so I'll try be concise
Done
NestedScrollConnection
to receive scroll events from theLazyColumn
, and build up aPullToLoadState
for handling offset and callbacks (Thanks [RFC] Swipe ReadingPage #468 by @boun for inspiration!)PullToLoadIndicator
NestedScrollConnection
to calculateisReaderScrollingDown
instead ofLazyListState
because it's more accurateTo do
Screen record:
2024-02-06.20.00.50.mp4