-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first yii2 draft #22
base: master
Are you sure you want to change the base?
first yii2 draft #22
Conversation
I don't fancy beign removed from the authors. We may need to mantain two different branches, to keep support for Yii 1.* users |
Sorry didn't wanna bother you! I just made a quick hack and wanted to mention the author for the changes! You are still their as author! Pls let me know how you'll be happy again! Von meinem iPhone gesendet Am 14.07.2013 um 23:28 schrieb Alex Urbano notifications@github.com:
|
I am not mad, just keep my name under the authors, and add yours there too, you can have multiple @author tags |
And - the composer renaming was due to get it working with packagist and my dev environment;) sorry once more Von meinem iPhone gesendet Am 14.07.2013 um 23:28 schrieb Alex Urbano notifications@github.com:
|
I'll do that;) thanks for not beeing mad. Von meinem iPhone gesendet Am 14.07.2013 um 23:33 schrieb Alex Urbano notifications@github.com:
|
I wouldn't mind being added as an author as well, if @Asgaroth thinks that's reasonable. And yeah, having this be a separate branch seems like a good way to go, as Yii 2 isn't going to be officially available for a while. Possibly have a Yii1 branch, a Yii2 branch and a master branch? Seems like it would be best for folks to use the appropriate branch so that if/when we shift to having Yii 2 be the default for this extension we don't end up with folks getting new code for their projects that they don't want ... |
I will review this tonight, create the appropriate branches/merge and add acorncom as author. |
I haven't forget about this, I just haven't have the time to look at it. |
Ok;) im still working in details;) |
This widget helped me much in Yii1. Now I'm newbie in Yii2 and I'm trying to apply it to Yii2.
|
How can I get it to Yii2 project and work with it? |
@MagSag I am not maintaining this anymore, this open PR should help as a ground to integrate with Yii2, I really have not worked with Yii2, so I can't help. |
@Asgaroth I'm not actively using it either, but we're still using the code on an old Yii1 project, so don't want to see it leave the Internet. Want to move it over to me? |
Sure, you already have full rights in this repo, do you need something more? On Thu, Dec 3, 2015 at 7:43 PM, David Baker notifications@github.com
|
Don't think I'm allowed to move the Github repo to my user as I'm not the owner ... |
Why would you need to do that? |
I thought you were wanting to stop being bothered about this repo ;-) Are you still wanting it to stay under your name and just have other folks maintaining it here? |
@acorncom It wont leave the internet and I am happy to give you any access required, but if I transfer it to anyone I’d rather it be somebody who is actively using it and maintaining it. |
👍 Sounds good to me :-) |
This will be my first yii2 draft for this extension - will port the rest of the code tomorrow