Update Carbon Locale, remove body requirement on pages, minor update to language core en, and update language es. #531
Conversation
update carbon locale on boot.
|
Thanks, this is already set here |
|
your only set locale to null or fr when testing config, but laravel localization locale doesn't work with Carbon locale, when i did this change i could see the messages from carbon translate fine. Edit made some other minor changes. Regards.- |
updated to lasted
Only show locale drop down if you have more than 1 language on the admin.
Modules/User/changelog.yml
Outdated
| @@ -1,5 +1,8 @@ | |||
| url: https://github.com/AsgardCms/Platform | |||
| versions: | |||
| "@unreleased": | |||
| changed: | |||
| - Adding a test the user token is correctly generated | |||
There was a problem hiding this comment.
Indentation is wrong here.
Not sure why you added this aswell as this was done before.
There was a problem hiding this comment.
fixes the indentation i added maybe you forgot to added to the user module.
|
Thanks but you're doing multiple things in one pull request, which makes it harder to review. PR title is : "Update Carbon Locale", but this PR does much more :D |
|
Im sorry, im making the changes via github web, and the commit i made go directly to my last open pull request, i will not make more changes until you check this PR and merge it, also going to fix the title as you requested. Regards.- |
kamekun
changed the title
|
Thanks! |
No description provided.