Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the payload body in the signature #24

Merged
merged 1 commit into from
Apr 12, 2020
Merged

Include the payload body in the signature #24

merged 1 commit into from
Apr 12, 2020

Conversation

gregeinfrank
Copy link
Contributor

@gregeinfrank gregeinfrank commented Apr 10, 2020 •
edited by asana-unito
Loading

The compare_digest was failing because we weren't including the payload body as part of the signature. I pushed this code, so if this PR syncs then we know it's working :)

Pull Request synchronized with Asana task

rohansub-asana
rohansub-asana approved these changes Apr 11, 2020
View reviewed changes
Copy link
Contributor

@rohansub-asana rohansub-asana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof looks like I never got the chance to test that part of it out 😬. Good catch!

@gregeinfrank gregeinfrank merged commit f6135fd into master Apr 12, 2020
@gregeinfrank gregeinfrank deleted the gregeinfrank-fix-signature branch April 12, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohansub-asana rohansub-asana rohansub-asana approved these changes

Assignees

@gregeinfrank gregeinfrank

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregeinfrank @rohansub-asana