-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 4.2 + podspec + version bump #7
Conversation
f55792f
to
d2bc17e
Compare
Verified this works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -0,0 +1 @@ | |||
4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own education, what is this file used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It helps a few command line tools work better. In this case, it was pod spec lint
that needed it.
See also: https://stackoverflow.com/questions/39587440/swift-what-is-a-swift-version-file
spec.source = { :git => 'https://github.com/asana/Drawsana.git', :tag => '0.9.2' } | ||
spec.source_files = 'Drawsana/**/*.swift' | ||
|
||
spec.platform = :ios, '9.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this version decided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same as the Xcode setting. Drawsana works all the way back to iOS 9. Probably earlier if we bothered to support it.
Before landing, I'll test this locally: https://guides.cocoapods.org/using/the-podfile.html#using-the-files-from-a-folder-local-to-the-machine