Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4.2 + podspec + version bump #7

Merged
merged 3 commits into from
Nov 5, 2018
Merged

Conversation

stevelandeyasana
Copy link
Collaborator

@stevelandeyasana stevelandeyasana commented Nov 2, 2018

@stevelandeyasana
Copy link
Collaborator Author

Verified this works.

Copy link

@nickiepucel nickiepucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1 @@
4.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own education, what is this file used for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It helps a few command line tools work better. In this case, it was pod spec lint that needed it.

See also: https://stackoverflow.com/questions/39587440/swift-what-is-a-swift-version-file

spec.source = { :git => 'https://github.com/asana/Drawsana.git', :tag => '0.9.2' }
spec.source_files = 'Drawsana/**/*.swift'

spec.platform = :ios, '9.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this version decided?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same as the Xcode setting. Drawsana works all the way back to iOS 9. Probably earlier if we bothered to support it.

@stevelandeyasana stevelandeyasana merged commit 7e9d02a into master Nov 5, 2018
@stevelandeyasana stevelandeyasana deleted the steve/podspec branch November 5, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants