Set XDG_RUNTIME_DIR perimssions to 700 #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitlith
requested review from
WhatAmISupposedToPutHere,
alyssarosenzweig,
slp and
teohhanhui
as code owners
From the spec: "Its Unix access mode MUST be 0700". Some software will check this and throw an error if it isn't. For instance, the xdg crate returns an `Err(XdgRuntimeDirInsecure(/*...*/))` under muvm. Signed-off-by: Kitlith <kitlith@kitl.pw>
Collaborator
|
Relevant section of the spec:
|
teohhanhui
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior seems to date back to the initial commit of the original C version of this tool:
teohhanhui/krun.legacy@01ae759#diff-ba1f55157a5e8661da39884a2669de7c912ff94d98134d6d520ed0468670e39bR198
Is anything relying on this extra permissiveness? I didn't notice any breakage in a quick test after patching this (consisting of launching Balatro through steam, nevermind that I normally just use the native build of love to run balatro) but that doesn't mean much.