Update env_logger to 0.11.8 and use stablized kv feature #170
+56
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musicinmybrain
requested review from
WhatAmISupposedToPutHere,
alyssarosenzweig,
slp and
teohhanhui
as code owners
Collaborator
|
Thanks for the PR. Could you please sign your commits as required by the DCO check? |
Signed-off-by: Benjamin A. Beasley <code@musicinmybrain.net>
Signed-off-by: Benjamin A. Beasley <code@musicinmybrain.net>
musicinmybrain
force-pushed
the
env_logger-stabilized-kv
branch
from
1d436d8 to
4cd9c2c
Compare
Contributor
Author
Done. |
teohhanhui
approved these changes
Jun 10, 2025
Replace "iter().any()" with "contains()" to make clippy happy. Signed-off-by: Sergio Lopez <slp@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
env_logger0.11.8, key-value support is stabilized behind thekvfeature, and theunstable-kvfeature is deprecated and eligible to be removed in a future patch release.This PR updates the
env_loggerdependency inmuvmfrom 0.11.3 to 0.11.8 and uses the newkvfeature instead of the now-deprecatedunstable-kvfeature.