Improve VRAM management in the guest #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move prepare_env_vars up in the main function, since in the next commit we're going to need the vector to be available earlier. Signed-off-by: Sergio Lopez <slp@redhat.com>
By default, HK sets the heap size to be half the size of the *guest* memory. Since commit 167744dc it's also possible to override the heap size by setting the HK_SYSMEM environment variable. Previously, the vram command line option was acting on the virtio-gpu SHM window. This didn't help in most cases because userspace doesn't really care nor is aware of it. Here, we set the SHM window of virtio-gpu to always be as large as the host's RAM, not because we expect VRAM to consume 100% of the RAM (which is obviously impossible) but to account for region fragmentation. Then, we use HK_SYSMEM to tell userspace the desired heap size (the closest thing to VRAM we can aim for), which will be set to either the value passed by the user throught the "vram" argument or half the size of the *host* RAM. Signed-off-by: Sergio Lopez <slp@redhat.com>
slp
requested review from
WhatAmISupposedToPutHere,
alyssarosenzweig,
hoshinolina and
teohhanhui
as code owners
alyssarosenzweig
approved these changes
Nov 5, 2024
Member
alyssarosenzweig
left a comment
alyssarosenzweig
left a comment
There was a problem hiding this comment.
I don't love the HK backdoor but until we have better kernel level stuff this seems reasonable +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.