Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken day 10 link #668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: broken day 10 link #668

wants to merge 1 commit into from

Conversation

omeralpi
Copy link

@omeralpi omeralpi commented Feb 3, 2023 •
edited
Loading

When I click on the 10th day on this page, it gives 404 error.

ThomSullivan
ThomSullivan approved these changes Feb 3, 2023
View reviewed changes
Copy link

@ThomSullivan ThomSullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! This will make the link function properly. Also the next page link on page 9 and the previous page link on page 11 need the same change.

@omeralpi
Copy link
Author

omeralpi commented Feb 4, 2023

Nice find! This will make the link function properly. Also the next page link on page 9 and the previous page link on page 11 need the same change.

I updated and pushed the next page link on page 9 and the previous page link on page 11.

ThomSullivan
ThomSullivan approved these changes Feb 4, 2023
View reviewed changes
Copy link

@ThomSullivan ThomSullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This will make the GitHub links work and does not affect the functionality of local links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomSullivan ThomSullivan ThomSullivan approved these changes

@abukar455a abukar455a abukar455a approved these changes

@Residenttt Residenttt Residenttt approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omeralpi @Residenttt @abukar455a @ThomSullivan