Gang bank #557
Merged
Gang bank #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoGuu
requested changes
May 5, 2019
BoGuu
requested changes
May 9, 2019
There was a problem hiding this comment.
A bunch of strings here not localised, do we have some and if not can we add them?
Other than that LGTM, does it work as expected? @imthatguyhere, did you test this already?
I have not. Not sure if @DomT602 has though. If not I can try to get some testing done on it in the next few days. |
BoGuu
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #190
Changes proposed in this pull request:
Fixes the above issue
I have tested my changes and corrected any errors found