Skip to content

Experimental / Closure => ES modules - transpiler #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 81 commits into
base: master
Choose a base branch
from
Draft

Experimental / Closure => ES modules - transpiler #2

wants to merge 81 commits into from

Conversation

Arxcis
Copy link
Owner

@Arxcis Arxcis commented Oct 16, 2020 •
edited
Loading

Demo - Transpiling grpc-web from closure-modules to es-modules

asciicast

Demo - Loading all modules in browser

Loading all the transpiled ES modules works as intended, loading grpc-web and all its goog-deps in 1 second in Chromium.

index.html - https://github.com/Arxcis/grpc-web/blob/experimental/build-esm-package/packages/grpc-web/index.html

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8" />
  </head>
  <body></body>
  <script type="module">
    import * as grpc from "./es_modules/exports.js";
  </script>
</html>

demochrome

Known issue - Circular dependencies cause uninitialized top-level values

The closure library the code I have generated has circular dependencies, which leads to undefined values.
image

Dependency-graph shows circular dependencies in goog.events.events.js and goog.events.eventtype.js

image

Entire grpc-web dependency-graph.
graph

Command to generate graph

madge es_modules/exports.js -i graph.png

Known isssue - Naming conflict/aliasing in goog.useragent.useragent.js

I am considering prefixing all file-scope variables with goog. googUseragent in this case.
image

Arxcis added 30 commits October 16, 2020 21:06
@Arxcis
add esm-build.js
8e76c06
@Arxcis
Add yarn esm command
a1a1cb5
@Arxcis
Rename esm-build.js -> closure-to-esm.mjs
8c2dd92
@Arxcis
Add esm/ to .gitignore
87bb44d
@Arxcis
Add rewrite() procedure
139e7f5
@Arxcis
Add match requireTypeType(
d0f33ff
@Arxcis
Rewrite require() and requireType()
3e2bbff
@Arxcis
Speedup by traversing breadth first and async
d9e0a0a
@Arxcis
Pluginize the rewrite step
171ea47
@Arxcis
Added rewriteProivdes() function
83969ae
@Arxcis
Add failing rewrite test
3126266
@Arxcis
Make tests for multiple exports pass
03ea5ff
@Arxcis
Emit intermediate package declarations
a5746cd 
- The pacakage declarations contain only re-exports
of modules within the package.
- This makes it easier to deal with modules
which exports multiple symbols.
- This makes it easier to deal with modules
which exports multiple symbols.
@Arxcis
DRAFT / Append re-export on package level
465639e
@Arxcis
Rename closure-to-esm -> closuretoesm
f6095d6
@Arxcis
Support requires with var
5ec463a
@Arxcis
Generalize rewriteRequires
7ed28bd
@Arxcis
Export REGEX_REQUIRE from rewriters
c1f0ee6
@Arxcis
Add support for removing exports.status = Status;
522d5b8
@Arxcis
Remove the [] = parts destructuring, args instead
ce750af
@Arxcis
Add support for nubmers in requries, example base64
97dcd78
@Arxcis
Add support for numbers more places
facc187
@Arxcis
Fix missing support for numberes in closuretoesm
be257ec
@Arxcis
Add failing test with multiple imports on same line
9f60ee6
@Arxcis
renamed ext from .mjs -> .js
336d11d
@Arxcis
Rewrite exports = -> export {}
9f1edd1
@Arxcis
Add exports to index.js if not exists yet
43d99bd
@Arxcis
Handle single left-side export
ce92055
@Arxcis
Special exports case left side declaration
c2f6ecc
@Arxcis
Rename index.js -> closuretoesm.js
c2bfec0
Arxcis added 25 commits October 18, 2020 17:49
@Arxcis
Add some hand-crafted patches to remove the fewer and fewer references
4235843 
to the goog.
@Arxcis
Add more patches to cover more edge-cases
e52c420
@Arxcis
Made some helper functions for common file opeartions
f67a5e2
@Arxcis
Wrap sed-string in execShellCommand function-call
6a3a042
@Arxcis
Add two new failing tests for exports
53b1c54
@Arxcis
Add index.html to test module loading in browser
5abb836
@Arxcis
rewriteExports simpler and covers more edge cases
11f0a91
@Arxcis
fixed error not being deleted
8533a37
@Arxcis
Regex final exports edge-case
185827c
@Arxcis
Plug final exports edge-case
1193599
@Arxcis
Refactor requires rewriter
1b2b259
@Arxcis
Fix ./.index.js bug
d20356f
@Arxcis
Add deleteLine grpc.web.Interceptor edge-case
02581ef
@Arxcis
Add googAsserts and domAsserts aliases
dd48370
@Arxcis
Add alias for debugLogger and debugLogRecord
2929e59
@Arxcis
Better goog.module() rewriter
a562033
@Arxcis
Export let Metadata
af6a23f
@Arxcis
More export fixeMore export fixess
1d2ef68
@Arxcis
Rewrite more exports in rewriteModule() function
21854d5
@Arxcis
add export TRUSTED_TYPES_POLICY_NAME to goog.js
ed6b0ed
@Arxcis
Declare before exporting
6ba2e99
@Arxcis
Defer exporting to the end of file
8fd99f3
@Arxcis
Import directly, instead of via index.js files
809eb55
@Arxcis
Merge paths from require and module rewriters before rewriting paths
fa2f0f3
@Arxcis
Fix safeHtmlToNode -> dom.safeHtmlToNode
8c9f801
@Arxcis Arxcis changed the title Experimental - Make tool for building an esm package Experimental - Closure => ES modules - transpiler Oct 20, 2020
@Arxcis Arxcis changed the title Experimental - Closure => ES modules - transpiler Experimental / Closure => ES modules - transpiler Oct 20, 2020
@Arxcis Arxcis mentioned this pull request Oct 20, 2020
Open
@huan huan mentioned this pull request Aug 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arxcis