add capability to retry connection after controller disconnects #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the script ended upon controller disconnection. This change allows for the user to specify if the script should retry connection upon a disconnect (within the timeout window)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the script ended upon controller disconnection. This change allows for the user to specify if the script should retry connection with controller upon a disconnect (within the timeout window).
Having the option for the script to retry (or not retry) connection is a quality of life improvement.
By default, this addition will try to reconnect upon a disconnect and the user can opt-out with retry=False parameter when listen() is invoked the first time.
Opt-in or opt-out into retry capability was more of a preference choice; it can definitely be changed to opt-in instead to maintain backwards-compatible behavior.