Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow controlling the camera with the keyboard #164

Merged
merged 4 commits into from
Jan 1, 2021
Merged

Conversation

ArturKovacs
Copy link
Owner

@ArturKovacs ArturKovacs commented Dec 26, 2020

Closes #159

With this, the configuration accepts the following bindings

[bindings]
zoom_in = ["x"]
zoom_out = ["z"]
pan_left = ["j"]
pan_right = ["l"]
pan_up = ["i"]
pan_down = ["k"]

@ArturKovacs
Copy link
Owner Author

@akimdi could you check if this does what you needed? You'd need to have rust installed to be able to build and run this so if you can't check this that's completely fine, I can just merge this as-is.

@akimdi
Copy link

akimdi commented Dec 29, 2020

@ArturKovacs Everything works for me. Thank you. Can I remap the keys?

@ArturKovacs
Copy link
Owner Author

Can I remap the keys?

Abolutely, that should be possible :) The guide on the website might help with that: https://arturkovacs.github.io/emulsion-website/bindings.html

Report back if something doesn't work.

@ArturKovacs
Copy link
Owner Author

@akimdi Could you remap the keys the way you wanted?

@akimdi
Copy link

akimdi commented Dec 30, 2020

@ArturKovacs Yes, but I found some bugs during testing.

  1. It hangs a little for a few seconds when I delete files one by one and there are no files left in the folder and then throws this error
Error occurred while loading image: Could not got current file descriptor
Error occurred while loading image: Could not got current file descriptor
Error while updating directory Error(DirError(Other("No such file or directory (os error 2)")), State { next_error: None, backtrace: InternalBacktrace { backtrace: None } })
  1. Not everywhere can create .Trash-1000 folder. For example, cannot do it in my ram folder I suspect that this is due to access rights. Other apps can do this.
Error while moving file '"1.jpg"' to trash: Remove { code: Some(1) }
  1. Can't assign -
    for example
[bindings]
zoom_in = ["+"]
zoom_out = ["-"]

Isn't working for me.

You are making an amazing product. Thanks for everything. Happy New Year 🎄

@akimdi
Copy link

akimdi commented Dec 30, 2020

This is what my config file looks like now
https://github.com/akimdi/emulsion/blob/master/cfg.toml

@ArturKovacs
Copy link
Owner Author

  1. I opened #166
  2. I added this information to #163
  3. I opened Input bindings is missing describing that 'subtract' must be used instead of '-' emulsion-website#6

You are making an amazing product. Thanks for everything. Happy New Year

Thank you so much! It makes me glad to know that you enjoy this program. Happy New Year to you too! 🎆

@ArturKovacs
Copy link
Owner Author

On top of the missing documentation, there was a bug in the code that prevented the alphanumeric - key from triggering actions bound to subtract

@ArturKovacs ArturKovacs merged commit fc64c8f into master Jan 1, 2021
@ArturKovacs ArturKovacs deleted the camera-keys branch January 1, 2021 17:31
@akimdi
Copy link

akimdi commented Jan 3, 2021

key from triggering actions bound to subtract

@ArturKovacs Thank you.

@ArturKovacs
Copy link
Owner Author

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow zooming and panning to be bound to key inputs
2 participants