Add UI feedback for when failed to copy the image.

src/clipboard_handler.rs

@@ -23,7 +23,6 @@ struct ClipboardRequestHandle {
 }
 
 pub struct ClipboardHandler {
-	prev_state: ClipboardState,
 	request_handle: Arc<ClipboardRequestHandle>,
 
 	thread_handle: Option<std::thread::JoinHandle<()>>,
@@ -44,7 +43,7 @@ impl ClipboardHandler {
 			})
 		};
 
-		ClipboardHandler { prev_state, request_handle, thread_handle: Some(handle) }
+		ClipboardHandler { request_handle, thread_handle: Some(handle) }
 	}
 
 	pub fn request_copy(&mut self, target: PathBuf) -> bool {
@@ -66,17 +65,8 @@ impl ClipboardHandler {
 		self.request_handle.condvar.notify_one();
 	}
 
-	pub fn requests_pending(&self) -> bool {
-		let state = self.request_handle.state.lock().unwrap();
-		if let ClipboardState::Pending(..) = &*state {
-			true
-		} else {
-			false
-		}
-	}
-
 	pub fn try_get_result(&self) -> Option<bool> {
-		let mut state = self.request_handle.state.lock().unwrap();
+		let state = self.request_handle.state.lock().unwrap();
 		match &*state {
 			ClipboardState::Pending(..) => None,
 			ClipboardState::Succeeded => Some(true),
@@ -142,9 +132,8 @@ impl ClipboardHandler {
 				}
 				Err("Could not set the clipboard image.".into())
 			});
-			let mut state_guard = request_handle.state.lock().unwrap();
-			*state_guard =
-				if result.is_ok() { ClipboardState::Succeeded } else { ClipboardState::Failed };
+			let mut state = request_handle.state.lock().unwrap();
+			*state = if result.is_ok() { ClipboardState::Succeeded } else { ClipboardState::Failed };
 		}
 	}
 }

src/widgets/copy_notification.rs

@@ -6,6 +6,7 @@ use gelatin::{label::Label, misc::*, picture::Picture, NextUpdate, Widget};
 
 static COPY_STARTED: &[u8] = include_bytes!("../../resource/copy-started.png");
 static COPY_READY: &[u8] = include_bytes!("../../resource/copy-ready.png");
+static COPY_FAILED: &[u8] = include_bytes!("../../resource/copy-failed.png");
 
 const READY_DISPLAY_TIME: Duration = Duration::from_secs(3);
 
@@ -14,6 +15,7 @@ pub struct CopyNotifications {
 	pub widget: Weak<Label>,
 	copy_started_img: Rc<Picture>,
 	copy_ready_img: Rc<Picture>,
+	copy_failed_img: Rc<Picture>,
 	finished: bool,
 	finished_time: std::time::Instant,
 }
@@ -22,6 +24,7 @@ impl CopyNotifications {
 	pub fn new(widget: &Rc<Label>) -> CopyNotifications {
 		let copy_started_img = Rc::new(Picture::from_encoded_bytes(COPY_STARTED));
 		let copy_ready_img = Rc::new(Picture::from_encoded_bytes(COPY_READY));
+		let copy_failed_img = Rc::new(Picture::from_encoded_bytes(COPY_FAILED));
 
 		widget.set_icon(None);
 		widget.set_ignore_layout(true);
@@ -37,23 +40,27 @@ impl CopyNotifications {
 			widget: Rc::downgrade(widget),
 			copy_started_img,
 			copy_ready_img,
+			copy_failed_img,
 			finished: true,
 			finished_time: Instant::now(),
 		}
 	}
 
 	pub fn set_started(&mut self) {
-		println!("Set started called");
 		let widget = self.widget.upgrade().unwrap();
 		widget.set_icon(Some(self.copy_started_img.clone()));
 		widget.set_visible(true);
 		self.finished = false;
 	}
 
-	pub fn set_finished(&mut self) {
-		println!("Set finished called");
+	pub fn set_finished(&mut self, succeeded: bool) {
 		let widget = self.widget.upgrade().unwrap();
-		widget.set_icon(Some(self.copy_ready_img.clone()));
+		let icon = if succeeded {
+			self.copy_ready_img.clone()
+		} else {
+			self.copy_failed_img.clone()
+		};
+		widget.set_icon(Some(icon));
 		self.finished_time = Instant::now();
 		self.finished = true;
 	}

src/widgets/picture_widget.rs

@@ -523,12 +523,12 @@ impl Widget for PictureWidget {
 			}
 		}
 		if let Some(clipboard_handler) = &data.clipboard_handler {
-			let request_pending = clipboard_handler.requests_pending();
+			let clipboard_result = clipboard_handler.try_get_result();
+			let request_pending = clipboard_result.is_none();
 			if data.clipboard_request_was_pending != request_pending {
-				if request_pending {
-					data.copy_notifications.set_started();
-				} else {
-					data.copy_notifications.set_finished();
+				match clipboard_result {
+					Some(succeeded) => data.copy_notifications.set_finished(succeeded),
+					None => data.copy_notifications.set_started(),
 				}
 				data.clipboard_request_was_pending = request_pending;
 			} else if request_pending {