a grid container #742
Merged
a grid container #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I like you implementation! Sharing the same variable for the column/row was smart. I always wanted to add it to FTXUI. I might want to do something a little bit more customized in order to have the column/row number be set by a variable, and support user to push new children. |
|
Glad you liked it! I was wondering how can I use external libraries like this one in FTXUI? How are you going to link it? |
I puished some CMakeLists configuration to What do you think about them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've written a simple grid container using Horizontal and Vertical Containers. But I think this should be put into the container.cpp instead of a different library. Which one would you prefer? Thank you.