Skip to content

Conversation

@dgutyanghs
Copy link

FSLineChart is awesome, very helpful in my App.
also, I add a gradient color for fill mode.
hope you enjoy!

Thanks!

@ArthurGuibert
Copy link
Owner

ArthurGuibert commented May 30, 2016

Thanks for the pull request! Is the gradient just for the background of the chart? Is it not something we want to be specific to the app? It wouldn't be hard to add the layer with a zPosition of -1 to be underneath the chart and then we wouldn't have to touch the FSLineChart class.

@dgutyanghs
Copy link
Author

Sorry, I hadn't make myself clear.
Why adding a property in FSLineChart.h
@property (nonatomic , strong) CAGradientLayer *gradientLayer;
because I only want to fill the area of fillLayer.path in the function:- (void)strokeChart, not the whole background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants