Bugfix: Add tests and code for pagination links #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bugfix: pagination links must be inside the links object, so I removed the pagination object and moved the links into the right place. I also added a example file for integration tests.
|
👍 There's one thing in the json-api documentation I don't feel totally ok with. It states that pagination likns MUST appear in the link objects that correspond to a collection. The only way to validate that it's a collection is checking if data is an array, but a relationship MUST contain at least one of links, data and meta. So if there can be a relationship with no data, we can't validate that the pagination refers to a collection. I'm not sure in this case if it wold be worth it check if there is data to validate it as array to allow pagination. What do you think? |
|
@fcastillo-es I'm going to merge and close this Bugfix. I opened #21 with your question. |
Art4
added a commit
that referenced
this pull request
Nov 6, 2015
Bugfix: Add tests and code for pagination links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pagination links must be inside the links object, so I removed the pagination object and moved the links into the right place. I also added a example file for integration tests.
This PR fixes #19.