fix: add experimental_allow_proto3_optional compile option #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
force-pushed
the
fix-protoc_compile_error
branch
from
91c6af3
to
2de0fa9
Compare
mwylde
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Thanks for the contribution! While we have been directing developers to install a newer version of protoc (i.e., in https://doc.arroyo.dev/developing/dev-setup#dependencies) it's great that's not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add experimental_allow_proto3_optional compile option
fixing issue #703