Add additional config options #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
force-pushed
the
even_more_configs
branch
from
9363301
to
3ca4331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new config system to make more parts of the system (which currently have hard-coded values) configurable:
default-checkpoint-interval: Default interval for checkpointingpipeline.allowed-restarts: How many restarts to allow before moving to failed (-1 for infinite)pipeline.healthy-duration: After this amount of time, we consider the job to be healthy and reset the restarts counterpipeline.worker-heartbeat-timeout: Number of seconds to wait for a worker heartbeat before considering it deadpipeline.worker-startup-time: Amount of time to wait for workers to start up before considering them failedpipeline.task-startup-time: Amount of time to wait for tasks to startup before considering it failed