Fix a bug in the k8s deployment where the worker. slots configuration… #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwylde Please help me review |
gbto
pushed a commit
to gbto/arroyo
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was deploying using k8s, I found that there seemed to be a problem with the configuration of the K8S_WORKER_SLOTS environment variable, and I fixed it to the correct value.
https://github.com/ArroyoSystems/arroyo/blob/5fc6fe06cbbdc866f232bd813eb5e8aff16bcb3a/k8s/arroyo/templates/controller.yaml#L104C1-L105C51
.Values.workerSlotsdoes not exist,.Values.worker.slotsexists, so I modified it to.Values.worker.slots