Allow non-leading underscores #94
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
It's true that they are allowed, the current regex is stricter than the one use by the react refresh runtime because at the beginning I was not checking the type of the right side of variable declaration. I'll check this weekend if this is safe to do just |
1 task
736-c41-2c1-e464fc974
added a commit
to Swiss-Armed-Forces/Loom
that referenced
this pull request
Dec 30, 2025
This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@eslint/eslintrc](https://github.com/eslint/eslintrc) | devDependencies | patch | [`3.3.1` → `3.3.3`](https://renovatebot.com/diffs/npm/@eslint%2feslintrc/3.3.1/3.3.3) | [](https://securityscorecards.dev/viewer/?uri=github.com/eslint/eslintrc) | | [@mui/types](https://github.com/mui/material-ui/tree/master/packages/mui-types) ([source](https://github.com/mui/material-ui/tree/HEAD/packages/mui-types)) | devDependencies | patch | [`7.4.8` → `7.4.9`](https://renovatebot.com/diffs/npm/@mui%2ftypes/7.4.8/7.4.9) | [](https://securityscorecards.dev/viewer/?uri=github.com/mui/material-ui) | | [@testing-library/react](https://github.com/testing-library/react-testing-library) | devDependencies | patch | [`16.3.0` → `16.3.1`](https://renovatebot.com/diffs/npm/@testing-library%2freact/16.3.0/16.3.1) | [](https://securityscorecards.dev/viewer/?uri=github.com/testing-library/react-testing-library) | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | devDependencies | patch | [`24.10.0` → `24.10.4`](https://renovatebot.com/diffs/npm/@types%2fnode/24.10.0/24.10.4) | [](https://securityscorecards.dev/viewer/?uri=github.com/DefinitelyTyped/DefinitelyTyped) | | [eslint-plugin-react-refresh](https://github.com/ArnaudBarre/eslint-plugin-react-refresh) | devDependencies | patch | [`0.4.24` → `0.4.26`](https://renovatebot.com/diffs/npm/eslint-plugin-react-refresh/0.4.24/0.4.26) | [](https://securityscorecards.dev/viewer/?uri=github.com/ArnaudBarre/eslint-plugin-react-refresh) | --- ### Release Notes <details> <summary>eslint/eslintrc (@​eslint/eslintrc)</summary> ### [`v3.3.3`](https://github.com/eslint/eslintrc/blob/HEAD/CHANGELOG.md#333-2025-11-28) [Compare Source](eslint/eslintrc@v3.3.1...fdb5298) ##### Bug Fixes - release v3.3.3 because publishing v3.3.2 failed ([#​211](eslint/eslintrc#211)) ([8aa555a](eslint/eslintrc@8aa555a)) </details> <details> <summary>testing-library/react-testing-library (@​testing-library/react)</summary> ### [`v16.3.1`](https://github.com/testing-library/react-testing-library/releases/tag/v16.3.1) [Compare Source](testing-library/react-testing-library@v16.3.0...v16.3.1) ##### Bug Fixes - Switch to trusted publishing ([#​1437](testing-library/react-testing-library#1437)) ([a2d37ff](testing-library/react-testing-library@a2d37ff)) </details> <details> <summary>ArnaudBarre/eslint-plugin-react-refresh (eslint-plugin-react-refresh)</summary> ### [`v0.4.26`](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/blob/HEAD/CHANGELOG.md#0426) [Compare Source](ArnaudBarre/eslint-plugin-react-refresh@v0.4.25...v0.4.26) - Revert changes to fix [#​93](ArnaudBarre/eslint-plugin-react-refresh#93) (fixes [#​95](ArnaudBarre/eslint-plugin-react-refresh#95)) ### [`v0.4.25`](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/blob/HEAD/CHANGELOG.md#0425) [Compare Source](ArnaudBarre/eslint-plugin-react-refresh@v0.4.24...v0.4.25) - Report cases like `export const ENUM = Object.keys(TABLE) as EnumType[];` (fixes [#​93](ArnaudBarre/eslint-plugin-react-refresh#93)) (reverted in 0.4.26) - Allow `_` in component names ([#​94](ArnaudBarre/eslint-plugin-react-refresh#94)) </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xMS4wIiwidXBkYXRlZEluVmVyIjoiNDIuNjguMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGUiXX0=--> See merge request swiss-armed-forces/cyber-command/cea/loom!231 Co-authored-by: shrewd-laidback palace <shrewd-laidback-palace-736-c41-2c1-e464fc974@swiss-armed-forces-open-source.ch> Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com>
736-c41-2c1-e464fc974
added a commit
to Swiss-Armed-Forces/Loom
that referenced
this pull request
Dec 30, 2025
chore(deps): update frontend dependencies (patch) (patch) This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@eslint/eslintrc](https://github.com/eslint/eslintrc) | devDependencies | patch | [`3.3.1` → `3.3.3`](https://renovatebot.com/diffs/npm/@eslint%2feslintrc/3.3.1/3.3.3) | [](https://securityscorecards.dev/viewer/?uri=github.com/eslint/eslintrc) | | [@mui/types](https://github.com/mui/material-ui/tree/master/packages/mui-types) ([source](https://github.com/mui/material-ui/tree/HEAD/packages/mui-types)) | devDependencies | patch | [`7.4.8` → `7.4.9`](https://renovatebot.com/diffs/npm/@mui%2ftypes/7.4.8/7.4.9) | [](https://securityscorecards.dev/viewer/?uri=github.com/mui/material-ui) | | [@testing-library/react](https://github.com/testing-library/react-testing-library) | devDependencies | patch | [`16.3.0` → `16.3.1`](https://renovatebot.com/diffs/npm/@testing-library%2freact/16.3.0/16.3.1) | [](https://securityscorecards.dev/viewer/?uri=github.com/testing-library/react-testing-library) | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | devDependencies | patch | [`24.10.0` → `24.10.4`](https://renovatebot.com/diffs/npm/@types%2fnode/24.10.0/24.10.4) | [](https://securityscorecards.dev/viewer/?uri=github.com/DefinitelyTyped/DefinitelyTyped) | | [eslint-plugin-react-refresh](https://github.com/ArnaudBarre/eslint-plugin-react-refresh) | devDependencies | patch | [`0.4.24` → `0.4.26`](https://renovatebot.com/diffs/npm/eslint-plugin-react-refresh/0.4.24/0.4.26) | [](https://securityscorecards.dev/viewer/?uri=github.com/ArnaudBarre/eslint-plugin-react-refresh) | --- ### Release Notes <details> <summary>eslint/eslintrc (@​eslint/eslintrc)</summary> ### [`v3.3.3`](https://github.com/eslint/eslintrc/blob/HEAD/CHANGELOG.md#333-2025-11-28) [Compare Source](eslint/eslintrc@v3.3.1...fdb5298) ##### Bug Fixes - release v3.3.3 because publishing v3.3.2 failed ([#​211](eslint/eslintrc#211)) ([8aa555a](eslint/eslintrc@8aa555a)) </details> <details> <summary>testing-library/react-testing-library (@​testing-library/react)</summary> ### [`v16.3.1`](https://github.com/testing-library/react-testing-library/releases/tag/v16.3.1) [Compare Source](testing-library/react-testing-library@v16.3.0...v16.3.1) ##### Bug Fixes - Switch to trusted publishing ([#​1437](testing-library/react-testing-library#1437)) ([a2d37ff](testing-library/react-testing-library@a2d37ff)) </details> <details> <summary>ArnaudBarre/eslint-plugin-react-refresh (eslint-plugin-react-refresh)</summary> ### [`v0.4.26`](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/blob/HEAD/CHANGELOG.md#0426) [Compare Source](ArnaudBarre/eslint-plugin-react-refresh@v0.4.25...v0.4.26) - Revert changes to fix [#​93](ArnaudBarre/eslint-plugin-react-refresh#93) (fixes [#​95](ArnaudBarre/eslint-plugin-react-refresh#95)) ### [`v0.4.25`](https://github.com/ArnaudBarre/eslint-plugin-react-refresh/blob/HEAD/CHANGELOG.md#0425) [Compare Source](ArnaudBarre/eslint-plugin-react-refresh@v0.4.24...v0.4.25) - Report cases like `export const ENUM = Object.keys(TABLE) as EnumType[];` (fixes [#​93](ArnaudBarre/eslint-plugin-react-refresh#93)) (reverted in 0.4.26) - Allow `_` in component names ([#​94](ArnaudBarre/eslint-plugin-react-refresh#94)) </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xMS4wIiwidXBkYXRlZEluVmVyIjoiNDIuNjguMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGUiXX0=--> See merge request swiss-armed-forces/cyber-command/cea/loom!231 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: open-source Pipeline <group_90701827_bot_ed04ae348bc5f40af9966fb8b6867e99@noreply.gitlab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underscores are allowed in React component names unless they're leading.