-
Notifications
You must be signed in to change notification settings - Fork 8
[DRAFT]: Rework to allow wine prefix selection for games #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… settings during iteration of owned games
Just curious, why would you want to do that when you can use umu? Seems like way more work. |
Just something personal I added. This fork was supposed to be just my subjective improvements before I decided I'll try to add per game prefix support. I'll remove it and keep the PR focused going forward |
You dont have to remove it, I was just curious why u use the runtime directly. Also I think it might be a good idea to split the pr, since then its easier to see what you did. So one pr for the exclusion, one for the settings, etc. Or do they depend on each other too much to split them? |
I can split exclusion into its own PR but any work towards separate wine prefixes and the JSON installation detection relies on the settings refactor. Moving it to the library allows easy access to the user-set wine prefix location when wine needs to be run and the cli/tui can access said settings as well when running a game |
This is some partial work towards per-game wine prefixes. I also happened to implement file exclusion for both the user's benefit and to make testing easier when downloading games. Will help close #44
Included work in this PR so far
Example of environmental variable configuration