-
Notifications
You must be signed in to change notification settings - Fork 24
Add SUSE Storage and Modify Rancher file #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: odidev <odidev@puresoftware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new commercial package entry for SUSE Storage and updates the existing Rancher open-source package information to reflect SUSE's acquisition of Rancher and provide more comprehensive details about the different Rancher offerings.
- Added SUSE Storage as a new commercial package offering
- Updated Rancher package metadata to reflect SUSE acquisition and provide clearer product differentiation
- Modified version information and added ARM64 support details for Rancher
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
content/commercial_packages/suse-storage.md | New file introducing SUSE Storage as a commercial Kubernetes storage solution |
content/opensource_packages/rancher.md | Updated to reflect SUSE acquisition, revised descriptions, and modified version support information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
download_url: https://github.com/rancher/rancher/releases | ||
works_on_arm: true | ||
supported_minimum_version: | ||
version_number: v2.5.8-rc15 | ||
release_date: 2021/04/30 | ||
version_number: 2.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version format is inconsistent with the original format. The original used 'v2.5.8-rc15' but the new version uses '2.2.0' without the 'v' prefix. This inconsistency could cause issues if the version format is expected to be consistent across the system.
version_number: 2.2.0 | |
version_number: v2.2.0 |
Copilot uses AI. Check for mistakes.
|
||
|
||
optional_info: | ||
homepage_url: https://www.rancher.com/ | ||
support_caveats: | ||
support_caveats: Rancher has been acquired by SUSE in December 2020. Kindly refer [here](https://www.suse.com/news/suse-completes-rancher-acquisition/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The phrase 'Kindly refer [here]' is awkward. Consider using 'Please see [here]' or 'For more information, see [here]' for better readability.
support_caveats: Rancher has been acquired by SUSE in December 2020. Kindly refer [here](https://www.suse.com/news/suse-completes-rancher-acquisition/). | |
support_caveats: Rancher has been acquired by SUSE in December 2020. Please see [here](https://www.suse.com/news/suse-completes-rancher-acquisition/). |
Copilot uses AI. Check for mistakes.
release_notes__recommended_minimum: | ||
other_info: | ||
other_info: Experimental support has been added for Arm64 in version 2.2.0, Users can manage Arm64 clusters with Rancher. Not all Rancher features would work with Arm64 clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after the comma. Should be 'version 2.2.0, Users' instead of 'version 2.2.0, Users'.
Copilot uses AI. Check for mistakes.
Signed-off-by: odidev odidev@puresoftware.com