Add navigation #1
Closed
+457
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that the `_set_prev_and_next` function correctly handles cases where the identifier is not found in the cached ID list or when the list contains a single ID, preventing errors and ensuring navigation functions correctly. It also adds a utility function `_find_identifier_index` to handle `ValueError` during index lookup.
Adds navigation links to feature 'links' array. When features are returned, navigation URLs are appended to the feature 'links' array. A base href is constructed from existing 'self' or 'collection' links if available. The navigation key is used as the link 'title', and the rendered template becomes the 'href'.
Refactors the provider to use a generic `links` configuration instead of a dedicated `navigation` block. This change allows for more flexible and customizable related links between collections, using templates for dynamic link generation. The new `links` configuration supports translated titles and other metadata, and the rendered links are added to the feature's `links` array. Also improves link handling, resolving hrefs and merging them with existing links.
Adds the ability to specify a base URL for generated links, allowing for absolute href resolution. This is achieved by introducing a `links_base` configuration option, which can be provided at the provider level. The code now resolves link hrefs against this base URL, ensuring that all generated links are absolute. This feature is particularly useful when running behind a reverse proxy or when a consistent base URL is required across different environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.