This repository was archived by the owner on Oct 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: limit html options in markdown parser #558
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osystem/laravel-ui into feat/external-link-dismiss-cookies
…osystem/laravel-ui into feat/external-link-dismiss-cookies
…osystem/laravel-ui
…/external-link-dont-show-again
Contributor
Author
|
Making it a draft to implement a new approach for external links Discussed here: https://cryptoarkproject.slack.com/archives/CLAGGC7LY/p1626898716137000 |
3 tasks
…osystem/laravel-ui into feat/external-link-dont-show-again
Contributor
Author
|
@ItsANameToo updated to detect all external links, and now also depends on this PR on common mark library As we talk now search for any external links and adds the confirmation modal automatically so we no longer need any component |
ItsANameToo
suggested changes
Jul 28, 2021
Co-authored-by: ItsANameToo <35610748+ItsANameToo@users.noreply.github.com>
…/external-link-dont-show-again
ItsANameToo
reviewed
Jul 28, 2021
ItsANameToo
approved these changes
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to https://app.clickup.com/t/p1bv2p and https://app.clickup.com/t/13kr2ar
Use with https://github.com/ArkEcosystem/marketsquare.io/pull/2164
*New now also depends on ArkEcosystemArchive/laravel-commonmark#19
string,ul, etc. (basically the ones that can be added with markdown)To test:
Merge this on this PR on marketsquare and try to add external links, the HTML tags, scripts, etc
Basically, try to broke the editor, the app or add scripts and ensure the content you add looks as expected once rendered
🌮 🌮 if you find a vulnerability
Checklist
icons.htmlfile and checked if my newly added icon is shown correctly (if necessary)