Skip to content
This repository was archived by the owner on Oct 1, 2021. It is now read-only.

Conversation

@alfonsobries
Copy link
Contributor

@alfonsobries alfonsobries commented Jul 13, 2021

Summary

Related to https://app.clickup.com/t/p1bv2p and https://app.clickup.com/t/13kr2ar
Use with https://github.com/ArkEcosystem/marketsquare.io/pull/2164

*New now also depends on ArkEcosystemArchive/laravel-commonmark#19

  • Adds the feature for adding a "don't remind me again" checkbox when opening an external
  • Ensures the markdown handles that external link component
  • Admits some basic HTML tags like string, ul, etc. (basically the ones that can be added with markdown)
  • Normalizes both HTML and markdown tags to ensure it looks great
  • Prevents XSS and errors
  • Adds test coverage

To test:

Merge this on this PR on marketsquare and try to add external links, the HTML tags, scripts, etc

Basically, try to broke the editor, the app or add scripts and ensure the content you add looks as expected once rendered

🌮 🌮 if you find a vulnerability

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Highjhacker and others added 30 commits June 14, 2021 18:21
…osystem/laravel-ui into feat/external-link-dismiss-cookies
…osystem/laravel-ui into feat/external-link-dismiss-cookies
@alfonsobries
Copy link
Contributor Author

Making it a draft to implement a new approach for external links

Discussed here: https://cryptoarkproject.slack.com/archives/CLAGGC7LY/p1626898716137000

@alfonsobries alfonsobries marked this pull request as draft July 21, 2021 20:47
…osystem/laravel-ui into feat/external-link-dont-show-again
@alfonsobries
Copy link
Contributor Author

@ItsANameToo updated to detect all external links, and now also depends on this PR on common mark library

As we talk now search for any external links and adds the confirmation modal automatically so we no longer need any component

@alfonsobries alfonsobries requested a review from ItsANameToo July 22, 2021 02:56
@ItsANameToo ItsANameToo marked this pull request as draft July 28, 2021 13:41
@ItsANameToo ItsANameToo marked this pull request as ready for review July 28, 2021 15:45
@ItsANameToo ItsANameToo changed the title refactor: markdown parser that accepts some html and link component refactor: limit html options in markdown parser Jul 29, 2021
@ItsANameToo ItsANameToo merged commit 2d2b2af into master Jul 29, 2021
@ItsANameToo ItsANameToo deleted the feat/external-link-dont-show-again branch July 29, 2021 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants