Skip to content
This repository was archived by the owner on Oct 1, 2021. It is now read-only.

Conversation

@alfonsobries
Copy link
Contributor

Summary

The ticket only mentions the case where the URL is invalid but is theoretically possible that Twitter server is down, is that is the case we will also have an exception.

  1. Validates the response of the Twitter API and returns an empty string if no valid result.
  2. If receives a connection exception will also return an empty string but in this case the cache will be only for 5 minutes so it can try again later.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo
Copy link
Collaborator

@ItsANameToo ItsANameToo changed the title fix: handle case twitter url is invalid or twitter is down fix: handle case twitter url is invalid or twitter is down Sep 8, 2021
@ItsANameToo ItsANameToo merged commit 68d28ca into master Sep 8, 2021
@ItsANameToo ItsANameToo deleted the fix/handle-invalid-twitter-links branch September 8, 2021 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants