This repository was archived by the owner on Oct 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
chore: upgrade to use latest version of phpstan #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Collaborator
|
@alfonsobries can you test this on |
Contributor
Author
|
@ItsANameToo yeah test passes and the editor works fine. It creates some new issues with phpstan but that can be handled on the PR we update this dependency |
Contributor
Author
|
@ItsANameToo Update: Thought you refer to ill check |
Contributor
Author
|
@ItsANameToo If you merge this new version into this PR it should work fine: https://github.com/ArkEcosystem/ark.dev/pull/191 |
Collaborator
|
@alfonsobries phpstan |
Contributor
Author
Contributor
|
@alfonsobries conflicts |
ItsANameToo
approved these changes
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates to latest version of laravel-phpstan, fixes new PHPstan errors
Checklist