Skip to content
This repository was archived by the owner on Oct 1, 2021. It is now read-only.

Conversation

@alfonsobries
Copy link
Contributor

Summary

Updates to latest version of laravel-phpstan, fixes new PHPstan errors

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo
Copy link
Collaborator

@alfonsobries can you test this on ark.dev to ensure we don't rely on overwriting any of the classes that are now made final?

@alfonsobries
Copy link
Contributor Author

@ItsANameToo yeah test passes and the editor works fine. It creates some new issues with phpstan but that can be handled on the PR we update this dependency

@alfonsobries
Copy link
Contributor Author

alfonsobries commented Jul 28, 2021

@ItsANameToo Update: Thought you refer to ark.io so ignore my previous comment (actually ark.io already have some phpstan error but we are not checking them in github actions)

ill check ark.dev in a moment

@alfonsobries
Copy link
Contributor Author

alfonsobries commented Jul 28, 2021

@ItsANameToo If you merge this new version into this PR it should work fine: https://github.com/ArkEcosystem/ark.dev/pull/191

@ItsANameToo
Copy link
Collaborator

@alfonsobries phpstan

@alfonsobries
Copy link
Contributor Author

@ItsANameToo

@faustbrian
Copy link
Contributor

@alfonsobries conflicts

@ItsANameToo ItsANameToo merged commit 1a31329 into master Sep 27, 2021
@ItsANameToo ItsANameToo deleted the chore/update-deps branch September 27, 2021 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants