Skip to content

Conversation

@roks0n
Copy link
Contributor

@roks0n roks0n commented Nov 11, 2018

Proposed changes

Fixes #62

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

None

@codecov-io
Copy link

Codecov Report

Merging #63 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   79.28%   79.42%   +0.14%     
==========================================
  Files          42       42              
  Lines         700      700              
  Branches       69       69              
==========================================
+ Hits          555      556       +1     
  Misses        115      115              
+ Partials       30       29       -1
Impacted Files Coverage Δ
crypto/identity/address.py 93.93% <100%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c739c...8a3901b. Read the comment docs.

@faustbrian faustbrian merged commit a0e58b8 into ArkEcosystem:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect call to address_from_private_key

3 participants